You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/05/17 01:31:11 UTC
Review Request 21596: SENTRY-213: Sentry schema tool doesn't handle
sentry.javax.jdo.* properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21596/
-----------------------------------------------------------
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Bugs: SENTRY-213
https://issues.apache.org/jira/browse/SENTRY-213
Repository: sentry
Description
-------
The sentry service expects the datanucleus and JDO config properties to be prefixed with 'sentry.'. The schema tool reads the JDBC connection driver from the same configuration. It's looking for javax.jdo prefix. This in not consistent with sentry store service.
The patch is to use the same config name.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 1ba1345
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java 17755e3
Diff: https://reviews.apache.org/r/21596/diff/
Testing
-------
Updated sentry schema tool tests.
Thanks,
Prasad Mujumdar
Re: Review Request 21596: SENTRY-213: Sentry schema tool doesn't handle
sentry.javax.jdo.* properties
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21596/#review43299
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On May 17, 2014, 12:12 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21596/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 12:12 a.m.)
>
>
> Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-213
> https://issues.apache.org/jira/browse/SENTRY-213
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The sentry service expects the datanucleus and JDO config properties to be prefixed with 'sentry.'. The schema tool reads the JDBC connection driver from the same configuration. It's looking for javax.jdo prefix. This in not consistent with sentry store service.
> The patch is to use the same config name.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 09af86d
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 1ba1345
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 2a5553c
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java 17755e3
>
> Diff: https://reviews.apache.org/r/21596/diff/
>
>
> Testing
> -------
>
> Updated sentry schema tool tests.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21596: SENTRY-213: Sentry schema tool doesn't handle
sentry.javax.jdo.* properties
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21596/
-----------------------------------------------------------
(Updated May 17, 2014, 12:12 a.m.)
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Changes
-------
Handle the driver name property similar to connection URL and username properties.
Bugs: SENTRY-213
https://issues.apache.org/jira/browse/SENTRY-213
Repository: sentry
Description
-------
The sentry service expects the datanucleus and JDO config properties to be prefixed with 'sentry.'. The schema tool reads the JDBC connection driver from the same configuration. It's looking for javax.jdo prefix. This in not consistent with sentry store service.
The patch is to use the same config name.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 09af86d
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java 1ba1345
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 2a5553c
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java 17755e3
Diff: https://reviews.apache.org/r/21596/diff/
Testing
-------
Updated sentry schema tool tests.
Thanks,
Prasad Mujumdar