[GitHub] ashb commented on a change in pull request #4609: [AIRFLOW-3782] Minor refinement of worker_autoscale in default_airflow.cfg

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4609: [AIRFLOW-3782] Minor refinement of worker_autoscale in default_airflow.cfg
URL: https://github.com/apache/airflow/pull/4609#discussion_r252681687
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -351,12 +351,13 @@ celery_app_name = airflow.executors.celery_executor
 # your worker box and the nature of your tasks
 worker_concurrency = 16
 
-# The minimum and maximum concurrency that will be used when starting workers with the
-# "airflow worker" command. Pick these numbers based on resources on
-# worker box and the nature of the task. If autoscale option is available worker_concurrency
-# will be ignored.
+# The maximum and minimum concurrency that will be used when starting workers with the
+# "airflow worker" command (always keep minimum processes, but grow to maximum if necessary).
+# Note the value should be "max_concurrency,min_concurrency"
+# Pick these numbers based on resources on worker box and the nature of the task.
+# If autoscale option is available, worker_concurrency will be ignored.
 # http://docs.celeryproject.org/en/latest/reference/celery.bin.worker.html#cmdoption-celery-worker-autoscale
-# worker_autoscale = 12,16
+# worker_autoscale = 16,12
 
 Review comment:
   What an counter-intuitive way of specifying it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services