[GitHub] [druid] suneet-s edited a comment on pull request #9449: Add Sql InputSource

[GitBox <gi...@apache.org>]

suneet-s edited a comment on pull request #9449:
URL: https://github.com/apache/druid/pull/9449#issuecomment-641334808


   > Regarding integration tests, I would say the original author or anyone can add it later. I think it's better to not add it in this PR since we don't have a framework to easily add such a test yet, which mean the PR size can grow large. We can open an issue for those integration tests and tag the next major release version so that those issues become release blockers.
   
   I've filed #10009 to add the integration tests - @a2l007 will you have time to add them before the 0.19 release?
   
   @pjain1 - I see you and @jon-wei were discussing a security model for Druid in #9380 Does adding an InputSource that allows a Druid user to read any SQL table - like the metadata store, config tables, etc. break the security model you had in mind for Druid?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org