You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2013/11/06 22:27:51 UTC
[1/2] git commit: Removed unused return value in SparkContext.runJob
Updated Branches:
refs/heads/master 951024fee -> aadeda5e7
Removed unused return value in SparkContext.runJob
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/a0c45651
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/a0c45651
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/a0c45651
Branch: refs/heads/master
Commit: a0c4565183b1dcfa816f280ddf9c60c4c117df06
Parents: bf4e613
Author: Lian, Cheng <rh...@gmail.com>
Authored: Wed Nov 6 23:18:59 2013 +0800
Committer: Lian, Cheng <rh...@gmail.com>
Committed: Wed Nov 6 23:18:59 2013 +0800
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/SparkContext.scala | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/a0c45651/core/src/main/scala/org/apache/spark/SparkContext.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/SparkContext.scala b/core/src/main/scala/org/apache/spark/SparkContext.scala
index 880b49e..2bfe7c7 100644
--- a/core/src/main/scala/org/apache/spark/SparkContext.scala
+++ b/core/src/main/scala/org/apache/spark/SparkContext.scala
@@ -796,11 +796,10 @@ class SparkContext(
val cleanedFunc = clean(func)
logInfo("Starting job: " + callSite)
val start = System.nanoTime
- val result = dagScheduler.runJob(rdd, cleanedFunc, partitions, callSite, allowLocal,
+ dagScheduler.runJob(rdd, cleanedFunc, partitions, callSite, allowLocal,
resultHandler, localProperties.get)
logInfo("Job finished: " + callSite + ", took " + (System.nanoTime - start) / 1e9 + " s")
rdd.doCheckpoint()
- result
}
/**
[2/2] git commit: Merge pull request #144 from liancheng/runjob-clean
Posted by rx...@apache.org.
Merge pull request #144 from liancheng/runjob-clean
Removed unused return value in SparkContext.runJob
Return type of this `runJob` version is `Unit`:
def runJob[T, U: ClassManifest](
rdd: RDD[T],
func: (TaskContext, Iterator[T]) => U,
partitions: Seq[Int],
allowLocal: Boolean,
resultHandler: (Int, U) => Unit) {
...
}
It's obviously unnecessary to "return" `result`.
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/aadeda5e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/aadeda5e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/aadeda5e
Branch: refs/heads/master
Commit: aadeda5e7697a433c82879033e758fbc403680dc
Parents: 951024f a0c4565
Author: Reynold Xin <rx...@apache.org>
Authored: Wed Nov 6 13:27:47 2013 -0800
Committer: Reynold Xin <rx...@apache.org>
Committed: Wed Nov 6 13:27:47 2013 -0800
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/SparkContext.scala | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------