You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Curt Arnold <ca...@apache.org> on 2010/05/24 07:34:11 UTC
log4j 2.0 code review process
I'm prepping to start diving into the recent code drop and trying to figure out how to do so in an effective way. I was thinking maybe the best way to approach it would be to use annotations or javadoc to make comments on the classes or methods. This fairly old article (http://java.sys-con.com/node/44700) describes using a @review Javadoc tag to capture code review comments. Does anyone have other suggestions on how to capture code review on the code drop?
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: log4j 2.0 code review process
Posted by Christian Grobmeier <gr...@gmail.com>.
>> This would perhaps be a good time to switch to a distributed SCM to avoid the reliance on a central server? This I would personally think is a good idea.
>>
>> There is no clear consensus on Stack Overflow on which one of bzr, git and hg to use, and I have no personal preference, except that good IDE support would be nice.
>>
>
> There is some support for git at http://www.apache.org/dev/git.html, http://wiki.apache.org/general/GitAtApache and http://git.apache.org. Unless someone wants to beat me to it, I'll request git mirroring for log4j tomorrow.
I think its doing no harm. But complete replace is not supported at
the ASF as far as I know at the moment
Christian
PS: and thanks for asking for Log4PHP too :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: log4j 2.0 code review process
Posted by Curt Arnold <ca...@apache.org>.
On May 24, 2010, at 12:08 PM, Thorbjørn Ravn Andersen wrote:
> Den 24/05/10 08.54, Ralph Goers skrev:
>> BTW - If I didn't say it before, this is the one place that git would be helpful. You could fork the code and do what you like and I could merge back what I like, etc. I don't really find git all that much more compelling for development once you have a trunk being co-developed, unless you change the development model to one where everyone works on their own fork and then merges back. While you can do this with SVN, git makes this really easy.
>>
> This would perhaps be a good time to switch to a distributed SCM to avoid the reliance on a central server? This I would personally think is a good idea.
>
> There is no clear consensus on Stack Overflow on which one of bzr, git and hg to use, and I have no personal preference, except that good IDE support would be nice.
>
There is some support for git at http://www.apache.org/dev/git.html, http://wiki.apache.org/general/GitAtApache and http://git.apache.org. Unless someone wants to beat me to it, I'll request git mirroring for log4j tomorrow.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: log4j 2.0 code review process
Posted by Thorbjørn Ravn Andersen <no...@gmail.com>.
Den 24/05/10 08.54, Ralph Goers skrev:
> BTW - If I didn't say it before, this is the one place that git would be helpful. You could fork the code and do what you like and I could merge back what I like, etc. I don't really find git all that much more compelling for development once you have a trunk being co-developed, unless you change the development model to one where everyone works on their own fork and then merges back. While you can do this with SVN, git makes this really easy.
>
This would perhaps be a good time to switch to a distributed SCM to
avoid the reliance on a central server? This I would personally think
is a good idea.
There is no clear consensus on Stack Overflow on which one of bzr, git
and hg to use, and I have no personal preference, except that good IDE
support would be nice.
--
Thorbjørn Ravn Andersen "...plus... Tubular Bells!"
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: log4j 2.0 code review process
Posted by Ralph Goers <ra...@dslextreme.com>.
BTW - If I didn't say it before, this is the one place that git would be helpful. You could fork the code and do what you like and I could merge back what I like, etc. I don't really find git all that much more compelling for development once you have a trunk being co-developed, unless you change the development model to one where everyone works on their own fork and then merges back. While you can do this with SVN, git makes this really easy.
On May 23, 2010, at 11:49 PM, Ralph Goers wrote:
> I realize this isn't what you mean, but I did a fairly lousy job on the javadoc. I'm traveling this week and may find some time in the hotel to see if I can't clean it up.
>
> As for adding @review tags, I'm good with pretty much anything. It looks like the Maven Javadoc plugin will let you add custom tags and then can generate a report on those tags, which would be very helpful to look at them.
>
> http://maven.apache.org/plugins/maven-javadoc-plugin/examples/tag-configuration.html shows how to add a tag and http://maven.apache.org/plugins/maven-javadoc-plugin/taglist.html is an example report. I'm not sure what they did to generate it.
>
> Ralph
>
> On May 23, 2010, at 10:34 PM, Curt Arnold wrote:
>
>> I'm prepping to start diving into the recent code drop and trying to figure out how to do so in an effective way. I was thinking maybe the best way to approach it would be to use annotations or javadoc to make comments on the classes or methods. This fairly old article (http://java.sys-con.com/node/44700) describes using a @review Javadoc tag to capture code review comments. Does anyone have other suggestions on how to capture code review on the code drop?
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: log4j 2.0 code review process
Posted by Ralph Goers <ra...@dslextreme.com>.
I realize this isn't what you mean, but I did a fairly lousy job on the javadoc. I'm traveling this week and may find some time in the hotel to see if I can't clean it up.
As for adding @review tags, I'm good with pretty much anything. It looks like the Maven Javadoc plugin will let you add custom tags and then can generate a report on those tags, which would be very helpful to look at them.
http://maven.apache.org/plugins/maven-javadoc-plugin/examples/tag-configuration.html shows how to add a tag and http://maven.apache.org/plugins/maven-javadoc-plugin/taglist.html is an example report. I'm not sure what they did to generate it.
Ralph
On May 23, 2010, at 10:34 PM, Curt Arnold wrote:
> I'm prepping to start diving into the recent code drop and trying to figure out how to do so in an effective way. I was thinking maybe the best way to approach it would be to use annotations or javadoc to make comments on the classes or methods. This fairly old article (http://java.sys-con.com/node/44700) describes using a @review Javadoc tag to capture code review comments. Does anyone have other suggestions on how to capture code review on the code drop?
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org