You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "JasonLeeWeiHern (via GitHub)" <gi...@apache.org> on 2023/05/10 02:34:35 UTC

[GitHub] [pinot] JasonLeeWeiHern opened a new issue, #10753: Wrong error message for incorrect column name during lookup

JasonLeeWeiHern opened a new issue, #10753:
URL: https://github.com/apache/pinot/issues/10753

   Hi team, we believe that the error message could be more informative when sendin a query using the lookup on a dimension table. 
   
   If we have an incorrect column name on the metric table in the look up query, it gives us an invalid segment/s error and returns no result. If we have an incorrect column name on the dimension table in the look up query, it gives us a QueryExecutionError.
   
   I think that if there is an incorrect column name on the metric table, it should give a QueryExecutionError instead of invalid segment/s error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #10753: Wrong error message for incorrect column name during lookup

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10753:
URL: https://github.com/apache/pinot/issues/10753#issuecomment-1572801823

   This warning is appended because these segments do not contain the column asked, thus being pruned before query execution. `QueryExecutionError` is reported when an error occurred during query execution.
   Ideally we should also report invalid segments when the column name is incorrect on a dimension table, but since dimension table is maintained differently (we maintain the whole table on heap), segment pruning step is not happening for dimension table.
   I can see the error message is slightly confusing because a common case when query contains a column that doesn't exist in the segment is when user just added a column into the schema but forgot to reload the table.
   
   Are you running the latest Pinot version? I think the latest version should throw exception on the broker side if a column doesn't exist in the table schema


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] JasonLeeWeiHern commented on issue #10753: Wrong error message for incorrect column name during lookup

Posted by "JasonLeeWeiHern (via GitHub)" <gi...@apache.org>.
JasonLeeWeiHern commented on issue #10753:
URL: https://github.com/apache/pinot/issues/10753#issuecomment-1581791502

   Hi jackie, the error i faced was using version 0.11.0.
   
   On our development environment, where table1 does not exist but table2 does exist, it also shows the same error:
   There are 19 invalid segment/s. This usually means that they were created with an older schema. Please reload the table in order to refresh these segments to the new schema.
   
   Query: SELECT LOOKUP('table1', 'areaName', 'cityId', cityID, 'geohash', geohash) AS areaName FROM table2 limit 10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] JasonLeeWeiHern commented on issue #10753: Wrong error message for incorrect column name during lookup

Posted by "JasonLeeWeiHern (via GitHub)" <gi...@apache.org>.
JasonLeeWeiHern commented on issue #10753:
URL: https://github.com/apache/pinot/issues/10753#issuecomment-1567973157

   Error message: There are 580 invalid segment/s. This usually means that they were created with an older schema. Please reload the table in order to refresh these segments to the new schema.
   
   Wrong query: 
   SELECT LOOKUP('table1', 'areaName', 'cityId', cityID, 'geohash', geohash) AS areaName FROM table2 limit 10 
   Correct query:
   SELECT LOOKUP('table1', 'areaName', 'cityId', cityID, 'geohash', geohash6) AS areaName FROM table2 limit 10 
   
   The column geohash in table 2 should be labelled as geohash6. With this incorrect column name, it throws the above error message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #10753: Wrong error message for incorrect column name during lookup

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10753:
URL: https://github.com/apache/pinot/issues/10753#issuecomment-1562122078

   Could you please provide the query and the response?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org