You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/03 08:47:27 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1284: HDDS-4058. Wrong use of AtomicBoolean in HddsDatanodeService
adoroszlai opened a new pull request #1284:
URL: https://github.com/apache/hadoop-ozone/pull/1284
## What changes were proposed in this pull request?
* `AtomicBoolean isStopped` should be `final`, not `volatile`, since the reference is not being changed
* `stop()` should use atomic `getAndSet()` instead of `get()` followed by `set()`
https://issues.apache.org/jira/browse/HDDS-4058
## How was this patch tested?
Not really tested, trivial code change.
CI passed:
https://github.com/adoroszlai/hadoop-ozone/runs/939478014
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] arp7 merged pull request #1284: HDDS-4058. Wrong use of AtomicBoolean in HddsDatanodeService
Posted by GitBox <gi...@apache.org>.
arp7 merged pull request #1284:
URL: https://github.com/apache/hadoop-ozone/pull/1284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1284: HDDS-4058. Wrong use of AtomicBoolean in HddsDatanodeService
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1284:
URL: https://github.com/apache/hadoop-ozone/pull/1284#issuecomment-668200324
Thanks @arp7 for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org