You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/18 07:43:47 UTC
[GitHub] [airflow] uranusjr opened a new pull request #22355: Correctly handle task_id mangling during unmapping
uranusjr opened a new pull request #22355:
URL: https://github.com/apache/airflow/pull/22355
Fix #22340.
Since BaseOperator modifies task_id according to the task group hierarchy, we can't use MappedOperator's task_id (which is already task-group-prefixed) directly when creating the unmapped BaseOperator. Instead, we need to keep a reference to the "original" task_id value as supplied by the user, and pass it into BaseOperator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22355: Correctly handle task_id mangling during unmapping
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22355:
URL: https://github.com/apache/airflow/pull/22355#issuecomment-1072251183
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22355: Correctly handle task_id mangling during unmapping
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22355:
URL: https://github.com/apache/airflow/pull/22355#issuecomment-1072251183
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #22355: Correctly handle task_id mangling during unmapping
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #22355:
URL: https://github.com/apache/airflow/pull/22355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org