[jira] [Commented] (SYNCOPE-410) Make username pattern configurable via account policy

["Guido Wimmel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNCOPE-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734849#comment-13734849 ] 

Guido Wimmel commented on SYNCOPE-410:
--------------------------------------

I've attached a patch with a suggested implementation. Remarks:
* if no pattern is set explicitly, the current pattern is applied (which should also ensure backwards compatibility)
* the user currently does not see the default pattern (PolicyBeanPanel is generic so it didn't see an easy way to show a corresponding remark)
* I've refactored the handling of the case check (isAllLowerCase() / isAllUpperCase()) to avoid the additional regular expressions
* as far as I could see AccountPolicyEnforcer wasn't covered by unit tests, so I added one that covers my changes
                
> Make username pattern configurable via account policy
> -----------------------------------------------------
>
>                 Key: SYNCOPE-410
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-410
>             Project: Syncope
>          Issue Type: Improvement
>          Components: console, core
>            Reporter: Guido Wimmel
>            Priority: Minor
>         Attachments: syncopeAccountPolicyPattern.patch
>
>
> Currently, the pattern for allowed usernames in Syncope is fixed to [a-zA-Z0-9-_@. ]+ (see AccountPolicyEnforcer). There are use cases for which this pattern does not fit (e.g. if one uses email addresses as usernames, e.g. the character '+' is also valid).
> I'd suggest making the username pattern configurable via the account policy. See also the corresponding discussion on the mailing list starting with [1].
> [1] http://syncope-dev.1063484.n5.nabble.com/AccountPolicyEnforcer-allowed-characters-in-username-td5714080.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira