You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2017/01/20 22:47:23 UTC
Review Request 55789: Deleted configuration groups are displayed
along with
active group with is_current value set to true using Ambari API's
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/
-----------------------------------------------------------
Review request for Ambari, Di Li and Jaimin Jetly.
Bugs: AMBARI-19641
https://issues.apache.org/jira/browse/AMBARI-19641
Repository: ambari
Description
-------
Following REST API returns deleted config group along with active groups with is_current value set to true.
http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS&is_current=true
Please here to the attachments ConfigHistory.png and service_config_versions_HDFS_is_current as an example.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 2d6ca20
Diff: https://reviews.apache.org/r/55789/diff/
Testing
-------
Tested manually. After applying patch, deleted config group entries were not returned for the above REST API call.
Thanks,
Amruta Borkar
Re: Review Request 55789: Deleted configuration groups are displayed
along
with active group with is_current value set to true using Ambari API's
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162648
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Jan. 20, 2017, 11:49 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55789/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 11:49 p.m.)
>
>
> Review request for Ambari, Di Li and Jaimin Jetly.
>
>
> Bugs: AMBARI-19641
> https://issues.apache.org/jira/browse/AMBARI-19641
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following REST API returns deleted config group along with active groups with is_current value set to true.
>
> http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS&is_current=true
>
> Please here to the attachments ConfigHistory.png and service_config_versions_HDFS_is_current as an example.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 2d6ca20
>
> Diff: https://reviews.apache.org/r/55789/diff/
>
>
> Testing
> -------
>
> Tested manually. After applying patch, deleted config group entries were not returned for the above REST API call.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 55789: Deleted configuration groups are displayed
along
with active group with is_current value set to true using Ambari API's
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162649
-----------------------------------------------------------
Please add Nate Cole for the review.
- Di Li
On Jan. 20, 2017, 11:49 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55789/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 11:49 p.m.)
>
>
> Review request for Ambari, Di Li and Jaimin Jetly.
>
>
> Bugs: AMBARI-19641
> https://issues.apache.org/jira/browse/AMBARI-19641
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following REST API returns deleted config group along with active groups with is_current value set to true.
>
> http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS&is_current=true
>
> Please here to the attachments ConfigHistory.png and service_config_versions_HDFS_is_current as an example.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 2d6ca20
>
> Diff: https://reviews.apache.org/r/55789/diff/
>
>
> Testing
> -------
>
> Tested manually. After applying patch, deleted config group entries were not returned for the above REST API call.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 55789: Deleted configuration groups are displayed
along
with active group with is_current value set to true using Ambari API's
Posted by Amruta Borkar <ar...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 11:49 p.m.)
Review request for Ambari, Di Li and Jaimin Jetly.
Bugs: AMBARI-19641
https://issues.apache.org/jira/browse/AMBARI-19641
Repository: ambari
Description
-------
Following REST API returns deleted config group along with active groups with is_current value set to true.
http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS&is_current=true
Please here to the attachments ConfigHistory.png and service_config_versions_HDFS_is_current as an example.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 2d6ca20
Diff: https://reviews.apache.org/r/55789/diff/
Testing
-------
Tested manually. After applying patch, deleted config group entries were not returned for the above REST API call.
Thanks,
Amruta Borkar