[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4061: Remove ArrayData from Array (#3880)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4061:
URL: https://github.com/apache/arrow-rs/pull/4061#discussion_r1163983399


##########
arrow-ipc/src/writer.rs:
##########
@@ -1107,94 +1107,29 @@ fn get_buffer_element_width(spec: &BufferSpec) -> usize {
     }
 }
 
-/// Returns byte width for binary value_offset buffer spec.

Review Comment:
   This logic had to be reworked to not rely on a non-zero ArrayData::offset to trigger the re-encoding logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org