You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by James Holmes <ja...@jamesholmes.com> on 2006/03/02 23:51:36 UTC
RE: svn commit: r382525 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/webxml/WebXml.java
Are you going to remove the call to init() in the Faces Servlet code as
well? I think it should removed there for consistency.
James
-----Original Message-----
From: mmarinschek@apache.org [mailto:mmarinschek@apache.org]
Sent: Thursday, March 02, 2006 4:53 PM
To: commits@myfaces.apache.org
Subject: svn commit: r382525 -
/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/we
bxml/WebXml.java
Author: mmarinschek
Date: Thu Mar 2 13:53:23 2006
New Revision: 382525
URL: http://svn.apache.org/viewcvs?rev=382525&view=rev
Log:
webXml is now inited whenever needed - thanks to James Holmes for pointing
this out.
Modified:
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
xml/WebXml.java
Modified:
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
xml/WebXml.java
URL:
http://svn.apache.org/viewcvs/myfaces/shared/trunk/core/src/main/java/org/ap
ache/myfaces/shared/webapp/webxml/WebXml.java?rev=382525&r1=382524&r2=382525
&view=diff
============================================================================
==
---
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
xml/WebXml.java (original)
+++
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
xml/WebXml.java Thu Mar 2 13:53:23 2006
@@ -118,8 +118,7 @@
WebXml webXml =
(WebXml)context.getApplicationMap().get(WEB_XML_ATTR);
if (webXml == null)
{
- log.error(WebXml.class.getName() + ".init must be called
before!");
- throw new IllegalStateException(WebXml.class.getName() + ".init
must be called before!");
+ init(context);
}
return webXml;
}
Re: svn commit: r382525 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/webxml/WebXml.java
Posted by Martin Marinschek <ma...@gmail.com>.
No, don't think so.
I think I will leave it in so that we can have a single point of
measurement for all initialization.
regards,
Martin
On 3/2/06, James Holmes <ja...@jamesholmes.com> wrote:
> Are you going to remove the call to init() in the Faces Servlet code as
> well? I think it should removed there for consistency.
>
> James
>
> -----Original Message-----
> From: mmarinschek@apache.org [mailto:mmarinschek@apache.org]
> Sent: Thursday, March 02, 2006 4:53 PM
> To: commits@myfaces.apache.org
> Subject: svn commit: r382525 -
> /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/we
> bxml/WebXml.java
>
> Author: mmarinschek
> Date: Thu Mar 2 13:53:23 2006
> New Revision: 382525
>
> URL: http://svn.apache.org/viewcvs?rev=382525&view=rev
> Log:
> webXml is now inited whenever needed - thanks to James Holmes for pointing
> this out.
>
> Modified:
>
> myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
> xml/WebXml.java
>
> Modified:
> myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
> xml/WebXml.java
> URL:
> http://svn.apache.org/viewcvs/myfaces/shared/trunk/core/src/main/java/org/ap
> ache/myfaces/shared/webapp/webxml/WebXml.java?rev=382525&r1=382524&r2=382525
> &view=diff
> ============================================================================
> ==
> ---
> myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
> xml/WebXml.java (original)
> +++
> myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/webapp/web
> xml/WebXml.java Thu Mar 2 13:53:23 2006
> @@ -118,8 +118,7 @@
> WebXml webXml =
> (WebXml)context.getApplicationMap().get(WEB_XML_ATTR);
> if (webXml == null)
> {
> - log.error(WebXml.class.getName() + ".init must be called
> before!");
> - throw new IllegalStateException(WebXml.class.getName() + ".init
> must be called before!");
> + init(context);
> }
> return webXml;
> }
>
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces