You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/19 14:33:28 UTC
[GitHub] [incubator-pekko] pjfanning opened a new issue, #115: ActorSystem start code has ref to Akka
pjfanning opened a new issue, #115:
URL: https://github.com/apache/incubator-pekko/issues/115
```
ManifestInfo(this).checkSameVersion("Akka", allModules, logWarning = true)
```
Need to work out what to replace this with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning closed issue #115: ActorSystem start code has ref to Akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #115: ActorSystem start code has ref to Akka
URL: https://github.com/apache/incubator-pekko/issues/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #115: ActorSystem start code has ref to Akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #115:
URL: https://github.com/apache/incubator-pekko/issues/115#issuecomment-1407725383
this is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] kw217 commented on issue #115: ActorSystem start code has ref to Akka
Posted by GitBox <gi...@apache.org>.
kw217 commented on issue #115:
URL: https://github.com/apache/incubator-pekko/issues/115#issuecomment-1398669851
As far as I can see this `$productName` is just used in the error string `"You are using version $highestVersion of $productName, but..."`, so we can safely change all occurrences to `"Pekko"`.
https://github.com/apache/incubator-pekko/blob/4ac0f00a477873965ee7d52e16faefb1de91fe3a/actor/src/main/scala/org/apache/pekko/util/ManifestInfo.scala#L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] kw217 commented on issue #115: ActorSystem start code has ref to Akka
Posted by GitBox <gi...@apache.org>.
kw217 commented on issue #115:
URL: https://github.com/apache/incubator-pekko/issues/115#issuecomment-1398675319
Though this does raise the question of what "older" means. Do we plan to release Pekko at `1.0.0` or `2.6.x`? If the former, we will need to tweak code like this to be a bit smarter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #115: ActorSystem start code has ref to Akka
Posted by GitBox <gi...@apache.org>.
pjfanning commented on issue #115:
URL: https://github.com/apache/incubator-pekko/issues/115#issuecomment-1398682937
> Though this does raise the question of what "older" means. Do we plan to release Pekko at `1.0.0` or `2.6.x`? If the former, we will need to tweak code like this to be a bit smarter.
It will be pekko 1.0.0. Why does this matter? Pekko versions will go up - pekko and akka are unrelated - different packages and jars - if someone has akka and pekko on their classpath, they should not interfere with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] kw217 commented on issue #115: ActorSystem start code has ref to Akka
Posted by "kw217 (via GitHub)" <gi...@apache.org>.
kw217 commented on issue #115:
URL: https://github.com/apache/incubator-pekko/issues/115#issuecomment-1398999240
Ah good point - in which case you'll want to remove most of the content of this list then:
https://github.com/apache/incubator-pekko/blob/main/actor/src/main/scala/org/apache/pekko/util/ManifestInfo.scala#L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org