You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/24 07:12:18 UTC
[PR] fix(ui): keep the selected sidebar item at regular weight [maka]
Astro-Han opened a new pull request, #5681:
URL: https://github.com/apache/maka/pull/5681
## Summary
Opening a task in the sidebar made its row visibly jump. A 60 fps screen recording of the real Electron app shows the only thing that changes in that frame is the title: Astryx's selected `SideNavItem` steps from font-weight 400 to 500, so the glyphs thicken (~12% more ink) and the truncated title widens a few pixels, moving its ellipsis. The row's height, position and ground stay the same, because the hover ground it already carried is the same paint as the selected one. So the text change is all you see.
Selection in the task sidebar is now the ground alone, as in Codex. The override targets `.maka-session-panel .astryx-side-nav-item[data-selected]` (Astryx's canonical state attribute), so every item in the sidebar changes together: task rows, project rows, 新任务 / 扩展 / 定时任务 and Settings. The settings modal's own navigation keeps Astryx's default.
Behavior change: while several rows are picked, the open row is no longer set apart from the other picked rows. They already shared one ground by design, and weight was the only difference. The main pane title still names the open task.
## Verification
- Real Electron (E2E fixture `chat-prompt-rail`, built from this branch): the selected item's computed `font-weight` is 400 before and after switching tasks, and its background is still `--color-neutral`.
- Storybook `Product/Shell Official AppShell / Default Layout`, light and dark: BEFORE is `main`'s storybook-static (computed weight 500), AFTER is this branch's (400). Same viewport. The only difference is the open row's weight.
- `npm run format`, `npm run lint`: clean.
- No test added. This is a single CSS declaration, and the story comparison below covers its visible result.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Claude Code diagnosed the jump from a screen recording and the live DOM, wrote the CSS change, and produced the comparison captures.
## Checklist
- [ ] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): keep the selected sidebar item at regular weight [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5681:
URL: https://github.com/apache/maka/pull/5681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org