[GitHub] [solr] alessandrobenedetti commented on a change in pull request #192: SOLR-15537: split 10-args LTRRescorer.scoreSingleHit method

[GitBox <gi...@apache.org>]

alessandrobenedetti commented on a change in pull request #192:
URL: https://github.com/apache/solr/pull/192#discussion_r671053864



##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingRescorer.java
##########
@@ -141,7 +141,10 @@ public void scoreFeatures(IndexSearcher indexSearcher,
       }
       for (int i = 0; i < rerankingQueries.length; i++) {
         if (modelWeights[i] != null) {
-          scoreSingleHit(indexSearcher, topN, modelWeights[i], docBase, hitUpto, new ScoreDoc(hit.doc, hit.score, hit.shardIndex), docID, rerankingQueries[i], scorers[i], rerankedPerModel[i]);
+          final ScoreDoc hit_i = new ScoreDoc(hit.doc, hit.score, hit.shardIndex);

Review comment:
       if i remember correctly in Java we are not supposed to use _ as separator, I think CamelCase should be used.
   Not a strong opinion anyway, we could rename the variable to something like 'currentHit' or similar, up to you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org