You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "DreamerPXY (via GitHub)" <gi...@apache.org> on 2023/05/18 05:47:06 UTC
[GitHub] [dubbo] DreamerPXY opened a new pull request, #12343: feat:remove jprotoc dependency
DreamerPXY opened a new pull request, #12343:
URL: https://github.com/apache/dubbo/pull/12343
## What is the purpose of the change
dubbo-compiler remove jprotoc dependecy
## Brief changelog
1. Remove jprotc dependency and add mustache dependency for template generation code
2. Retain the ProtoTypeMap provided by the original jprotc for storing message types parsed from proto
3. Remove ProtocPlugin and use Dubbo's own DubboProtocPlugin as the main entry point for protoc plugin calls
4. DubboProtocPlugin no longer provides debug methods and only supports FEATURE_ PROTO3_ OPTIONAL
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12343: feat:remove jprotoc dependency
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12343:
URL: https://github.com/apache/dubbo/pull/12343#issuecomment-1552847082
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12343)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12343&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12343&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12343&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=CODE_SMELL) [29 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12343&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12343&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12343&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12343&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12343&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on pull request #12343: feat:remove jprotoc dependency
Posted by "EarthChen (via GitHub)" <gi...@apache.org>.
EarthChen commented on PR #12343:
URL: https://github.com/apache/dubbo/pull/12343#issuecomment-1560407334
relate https://github.com/apache/dubbo/issues/12381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a diff in pull request #12343: feat:remove jprotoc dependency
Posted by "EarthChen (via GitHub)" <gi...@apache.org>.
EarthChen commented on code in PR #12343:
URL: https://github.com/apache/dubbo/pull/12343#discussion_r1197404618
##########
dubbo-compiler/pom.xml:
##########
@@ -37,8 +37,9 @@
<dependencies>
<dependency>
- <groupId>com.salesforce.servicelibs</groupId>
- <artifactId>jprotoc</artifactId>
+ <groupId>com.github.spullara.mustache.java</groupId>
Review Comment:
format
##########
dubbo-compiler/README.md:
##########
@@ -0,0 +1,20 @@
+## dubbo-complier移除jpotoc依赖
Review Comment:
pls use english
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:remove jprotoc dependency [dubbo]
Posted by "DreamerPXY (via GitHub)" <gi...@apache.org>.
DreamerPXY closed pull request #12343: feat:remove jprotoc dependency
URL: https://github.com/apache/dubbo/pull/12343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #12343: feat:remove jprotoc dependency
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #12343:
URL: https://github.com/apache/dubbo/pull/12343#issuecomment-1552790814
@guohao PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] dongxuwang commented on a diff in pull request #12343: feat:remove jprotoc dependency
Posted by "dongxuwang (via GitHub)" <gi...@apache.org>.
dongxuwang commented on code in PR #12343:
URL: https://github.com/apache/dubbo/pull/12343#discussion_r1199707127
##########
dubbo-compiler/src/main/java/org/apache/dubbo/gen/AbstractGenerator.java:
##########
@@ -261,6 +261,20 @@ private List<PluginProtos.CodeGeneratorResponse.File> buildFile(ServiceContext c
return files;
}
+ protected String applyTemplate(@Nonnull String resourcePath, @Nonnull Object generatorContext) {
+ Preconditions.checkNotNull(resourcePath, "resourcePath");
+ Preconditions.checkNotNull(generatorContext, "generatorContext");
+ InputStream resource = MustacheFactory.class.getClassLoader().getResourceAsStream(resourcePath);
+ if (resource == null) {
+ throw new RuntimeException("Could not find resource " + resourcePath);
+ } else {
+ InputStreamReader resourceReader = new InputStreamReader(resource, Charsets.UTF_8);
+ Mustache template = MUSTACHE_FACTORY.compile(resourceReader, resourcePath);
+ return template.execute(new StringWriter(), generatorContext).toString();
+ }
+ }
+
+
Review Comment:
I think this is the redundant blank line needs to be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org