You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/23 08:53:55 UTC
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#72: HDDS-2341. Validate tar entry path during extraction
adoroszlai commented on a change in pull request #72: HDDS-2341. Validate tar entry path during extraction
URL: https://github.com/apache/hadoop-ozone/pull/72#discussion_r337924202
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java
##########
@@ -114,12 +116,11 @@
}
}
+ @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
Review comment:
Thanks @dineshchitlangia for the review. I agree about the need for explanation, I was just kind of lazy adding it. In fact, I think it's simpler to replace the suppression with a null check. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org