os-windows/8443: Headers included in wrong order in "os.h"

[Ben Blank <bl...@mac.com>]

>Number:         8443
>Category:       os-windows
>Synopsis:       Headers included in wrong order in "os.h"
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Mon Oct 01 12:10:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     blank3@mac.com
>Release:        1.3.20
>Organization:
apache
>Environment:
Windows 2000 Professional SP2, Visual Studio 7.0 build 9254 (aka VS.NET Beta 2)
>Description:
(Note: I was unable to determine if this is the same issue described in PR#7387.  If so, I apologize for the duplication.)

When compiling any project in Apache 1.3.20, hundreds of redefinition errors are generated by <winsock2.h>
>How-To-Repeat:
On any computer running any beta of VS.NET, simply build any project in Apache 1.3.20.
>Fix:
The Windows SDK headers require that <winsock2.h> be #included before <windows.h>, as <windows.h> #includes <winsock.h>, which conflicts with <winsock2.h>.  The solution is to move the "#include <winsock2.h>" line in "os.h" up one line, so that it is before <windows.h>.
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]