You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/08/26 02:33:13 UTC

[Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

#172: Implement sticky panels using Bootstrap affix plugin
------------------------------------+-----------------------
 Reporter:  olemis                  |      Owner:  olemis
     Type:  enhancement             |     Status:  new
 Priority:  major                   |  Milestone:  Release 2
Component:  ui design               |    Version:
 Keywords:  bootstrap sticky affix  |
------------------------------------+-----------------------
 Recently [http://twitter.github.com/bootstrap/ Bootstrap] ''2.1.0'' has
 been released including
 [http://twitter.github.com/bootstrap/javascript.html#affix Affix plugin].
 In a few words it's a feature quite similar to [#65 sticky panels] . I
 recommend to upgrade our copy and distribute that version and use that
 plugin instead of current solution .

 '''PS:''' It's not about that ours doesn't work or is broken . It's just
 that it is convenient to reuse ''Bootstrap'' 's supported solution while
 we focus on other things ''';)'''

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#172: Implement sticky panels using Bootstrap affix plugin
--------------------------+------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap sticky affix
--------------------------+------------------------------------

Comment (by olemis):

 Attached patches implement sticky panels using
 [http://twitter.github.com/bootstrap/javascript.html#affix Bootstrap
 Affix] plugin and some extra magic needed to make it work smoothly.
 Ticket, milestone and product UI have been updated as well.

 ==== Dashboard plugin ====

 Apply the following patches in given order against r1371737

 {{{
 #!sh

 $ hg qapplied
 t172/t172_r1371737_bootstrap_2.1.0.diff
 t172/t172_r1371737_bootstrap_affix_models.diff

 }}}

 ==== Theme plugin ====

 Apply the following patches in given order against r1365626

 {{{
 #!sh

 $ hg qapplied
 t172/t172_r1365626_bootstrap_affix.diff
 t172/t172_r1365626_bootstrap_affix_ticket.diff
 t172/t172_r1365626_bootstrap_affix_models.diff

 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#172: Implement sticky panels using Bootstrap affix plugin
--------------------------+------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap sticky affix
--------------------------+------------------------------------

Comment (by jdreimann):

 Replying to [comment:1 olemis]:
 > I've noticed that (at least) [http://twitter.github.com/bootstrap/base-
 css.html#typography typography] and
 [http://twitter.github.com/bootstrap/components.html#breadcrumbs
 breadcrumbs] are slightly different in version ''2.1.0'' . What shall we
 do about that ?

 I'm happy to just adopt the new 2.1.0 defaults, including the Affix
 plugin. Our current sticky panel code does seem to be broken by the way,
 as seen in ticket #88, where you can see it somewhat offset from the top.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#172: Implement sticky panels using Bootstrap affix plugin
--------------------------+------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  closed
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:  fixed        |   Keywords:  bootstrap sticky affix
--------------------------+------------------------------------
Changes (by gjm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Regression probably due to this noted in #197

 Otherwise, this seems fine.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#172: Implement sticky panels using Bootstrap affix plugin
--------------------------+------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap sticky affix
--------------------------+------------------------------------

Comment (by olemis):

 I've noticed that (at least) [http://twitter.github.com/bootstrap/base-
 css.html#typography typography] and
 [http://twitter.github.com/bootstrap/components.html#breadcrumbs
 breadcrumbs] are slightly different in version ''2.1.0'' . What shall we
 do about that ?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #172: Implement sticky panels using Bootstrap affix plugin

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#172: Implement sticky panels using Bootstrap affix plugin
--------------------------+------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap sticky affix
--------------------------+------------------------------------

Comment (by gjm):

 r1381141 upgrades bootstrap to 2.1.0

 r1381143 uses affix plugin for sticky panels

 r1381144 changes for including affix plugin

 r1381145 provides tweaks for ticket, product and milestone views

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/172#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker