You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/30 07:16:24 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #3662: change pre_cast_lit_in_comparison to unwrap_cast_in_comparison

liukun4515 commented on code in PR #3662:
URL: https://github.com/apache/arrow-datafusion/pull/3662#discussion_r984282056


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -779,23 +777,6 @@ async fn csv_explain() {
 
     // Note can't use `assert_batches_eq` as the plan needs to be
     // normalized for filenames and number of cores
-    let expected = vec![
-        vec![
-            "logical_plan",
-            "Projection: #aggregate_test_100.c1\
-             \n  Filter: CAST(#aggregate_test_100.c2 AS Int32) > Int32(10)\

Review Comment:
   `CAST(#aggregate_test_100.c2 AS Int32)` will be converted to `#aggregate_test_100.c2`, and the `Int32(10)` will be converted to `Int8(10)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org