[GitHub] azai91 commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging

[GitBox <gi...@apache.org>]

azai91 commented on a change in pull request #11262: [MXNET-542] Fix mkldnn performance regression + improve test logging
URL: https://github.com/apache/incubator-mxnet/pull/11262#discussion_r195816698
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
 ##########
 @@ -327,7 +327,8 @@ typedef std::pair<OutDataOp, mkldnn::memory *> mkldnn_output_t;
  * If these two functions are used, we have to call CommitOutput to write
  * the output back to the output NDArray.
  */
-mkldnn_output_t CreateMKLDNNMem(const NDArray &arr,
+mkldnn_output_t CreateMKLDNNMem(const NDArray &out_arr,
 
 Review comment:
   I thought about that, but then technically wouldn't all shouldn't all operators be eligible to use WriteInPlace? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services