You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/25 08:10:45 UTC

[GitHub] [orc] dirtysalt commented on a change in pull request #670: Update ORCv1.md: Fix documentation about bitset in bloom filter section

dirtysalt commented on a change in pull request #670:
URL: https://github.com/apache/orc/pull/670#discussion_r601176072



##########
File path: site/specification/ORCv1.md
##########
@@ -1297,7 +1297,7 @@ in a bloom filter is as follows:
   * position = combinedHash % m
 6. Set the position in bit set. The LSB 6 bits identifies the long index
    within bitset and bit position within the long uses little endian order.
-  * bitset[position >>> 6] \|= (1L << position);
+  * bitset[position >> 6] \|= (1L << (position & 0x3f));

Review comment:
       Thanks. Sure, I have updated the PR description and title.  Do you think it's clear enough? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org