You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/09/26 16:25:23 UTC

[activemq-artemis] 02/02: change some scopes to test only, supply logging impl via assembly distribution pom only

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit aeb9e4b0e4a7b5d7c2be3f98bc4c36826f5cdb1e
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Mon Sep 26 17:24:49 2022 +0100

    change some scopes to test only, supply logging impl via assembly distribution pom only
---
 artemis-cli/pom.xml                | 2 +-
 artemis-distribution/pom.xml       | 7 +++++++
 artemis-jakarta-server/pom.xml     | 2 +-
 artemis-jms-server/pom.xml         | 2 +-
 artemis-ra/pom.xml                 | 2 +-
 artemis-server-osgi/pom.xml        | 2 +-
 artemis-server/pom.xml             | 2 +-
 artemis-service-extensions/pom.xml | 2 +-
 tests/activemq5-unit-tests/pom.xml | 1 +
 9 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/artemis-cli/pom.xml b/artemis-cli/pom.xml
index e517f4e705..d24f02a285 100644
--- a/artemis-cli/pom.xml
+++ b/artemis-cli/pom.xml
@@ -96,7 +96,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
 
       <dependency>
diff --git a/artemis-distribution/pom.xml b/artemis-distribution/pom.xml
index 0bca85555e..a6fa4ac1fa 100644
--- a/artemis-distribution/pom.xml
+++ b/artemis-distribution/pom.xml
@@ -113,6 +113,13 @@
          <version>${project.version}</version>
       </dependency>
 
+      <!-- Logging implementation -->
+      <dependency>
+         <groupId>org.apache.logging.log4j</groupId>
+         <artifactId>log4j-slf4j-impl</artifactId>
+         <scope>runtime</scope>
+      </dependency>
+
       <!-- dependencies -->
        <dependency>
            <groupId>org.apache.activemq</groupId>
diff --git a/artemis-jakarta-server/pom.xml b/artemis-jakarta-server/pom.xml
index e05dd57d86..869f27d8e8 100644
--- a/artemis-jakarta-server/pom.xml
+++ b/artemis-jakarta-server/pom.xml
@@ -43,7 +43,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
       <dependency>
          <groupId>org.apache.activemq</groupId>
diff --git a/artemis-jms-server/pom.xml b/artemis-jms-server/pom.xml
index f7ebfb1dec..0089a86073 100644
--- a/artemis-jms-server/pom.xml
+++ b/artemis-jms-server/pom.xml
@@ -46,7 +46,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
       <dependency>
          <groupId>org.apache.activemq</groupId>
diff --git a/artemis-ra/pom.xml b/artemis-ra/pom.xml
index 5195329b98..84973f1a26 100644
--- a/artemis-ra/pom.xml
+++ b/artemis-ra/pom.xml
@@ -88,7 +88,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
    </dependencies>
 
diff --git a/artemis-server-osgi/pom.xml b/artemis-server-osgi/pom.xml
index 65dec33f83..776e1d74f6 100644
--- a/artemis-server-osgi/pom.xml
+++ b/artemis-server-osgi/pom.xml
@@ -92,7 +92,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope>
+         <scope>test</scope>
       </dependency>
       <dependency>
          <groupId>junit</groupId>
diff --git a/artemis-server/pom.xml b/artemis-server/pom.xml
index bdc22327e7..4656a4e4ad 100644
--- a/artemis-server/pom.xml
+++ b/artemis-server/pom.xml
@@ -48,7 +48,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
       <dependency>
          <groupId>com.google.guava</groupId>
diff --git a/artemis-service-extensions/pom.xml b/artemis-service-extensions/pom.xml
index 35f1ffa739..bb3c43c914 100644
--- a/artemis-service-extensions/pom.xml
+++ b/artemis-service-extensions/pom.xml
@@ -46,7 +46,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
-         <scope>runtime</scope> <!-- TODO: decide whether to only supply via assembly or here -->
+         <scope>test</scope>
       </dependency>
       <dependency>
          <groupId>org.apache.activemq</groupId>
diff --git a/tests/activemq5-unit-tests/pom.xml b/tests/activemq5-unit-tests/pom.xml
index d891937ba5..922e9cde71 100644
--- a/tests/activemq5-unit-tests/pom.xml
+++ b/tests/activemq5-unit-tests/pom.xml
@@ -46,6 +46,7 @@
       <dependency>
          <groupId>org.apache.logging.log4j</groupId>
          <artifactId>log4j-slf4j-impl</artifactId>
+         <scope>test</scope>
       </dependency>
 
       <dependency>