You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/06 19:14:00 UTC

[jira] [Commented] (GEODE-8782) Add getPrincipal method to FunctionContext interface

    [ https://issues.apache.org/jira/browse/GEODE-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260000#comment-17260000 ] 

ASF GitHub Bot commented on GEODE-8782:
---------------------------------------

jdeppe-pivotal opened a new pull request #5880:
URL: https://github.com/apache/geode/pull/5880


   - Add the ability to retrieve the Principal from the FunctionContext
     when a SecurityManager is enabled.
   
   (cherry picked from commit a42f89ab48aaca9aac96a34e80a9b3b2d46bcddd)
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add getPrincipal method to FunctionContext interface
> ----------------------------------------------------
>
>                 Key: GEODE-8782
>                 URL: https://issues.apache.org/jira/browse/GEODE-8782
>             Project: Geode
>          Issue Type: New Feature
>          Components: core
>            Reporter: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> In some cases it would be very helpful to have access to the {{Principal}} when executing a function.
> It may seem obvious that if one has a reference to the {{cache}} that you could get to the {{SecurityManager}} and extract the {{Subject}} and thus the {{Principal}} from there. However, in some cases, Geode will seamlessly proxy a function call from one server to the other. This will typically happen with {{onRegion}} calls and partitioned regions. In such cases, the security context is lost and thus the principal is not accessible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)