You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/11 21:58:21 UTC
Review Request 37366: Resources: finalizing Resources.java
refactoring.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Converting `Resources` into Mesos resource container, adding coverage and introducing `filter()` method.
Further progress on `filter()` is blocked until we upgrade to Mesos 0.23.0.
Will not apply cleanly, diffed against 37153.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/Resources.java e38024506df3c0293a0d70def0e8ca5adc3ed6a2
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java d1294e238385c4cb060351b7cca6cd6700ada0a3
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 8bc56b26d3481b7ce456e6a1a91b4ff6c8010bb6
Diff: https://reviews.apache.org/r/37366/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37366: Resources: finalizing Resources.java
refactoring.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/#review94987
-----------------------------------------------------------
This patch does not apply cleanly on master (cbc42c4), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 11, 2015, 7:59 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37366/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 7:59 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1415
> https://issues.apache.org/jira/browse/AURORA-1415
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Converting `Resources` into Mesos resource container, adding coverage and introducing `filter()` method.
>
> Further progress on `filter()` is blocked until we upgrade to Mesos 0.23.0.
>
> Will not apply cleanly, diffed against 37153.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/Resources.java e38024506df3c0293a0d70def0e8ca5adc3ed6a2
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java d1294e238385c4cb060351b7cca6cd6700ada0a3
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 8bc56b26d3481b7ce456e6a1a91b4ff6c8010bb6
>
> Diff: https://reviews.apache.org/r/37366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37366: Resources: finalizing Resources.java
refactoring.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 7:59 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Adding ticket.
Bugs: AURORA-1415
https://issues.apache.org/jira/browse/AURORA-1415
Repository: aurora
Description
-------
Converting `Resources` into Mesos resource container, adding coverage and introducing `filter()` method.
Further progress on `filter()` is blocked until we upgrade to Mesos 0.23.0.
Will not apply cleanly, diffed against 37153.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/Resources.java e38024506df3c0293a0d70def0e8ca5adc3ed6a2
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java d1294e238385c4cb060351b7cca6cd6700ada0a3
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 8bc56b26d3481b7ce456e6a1a91b4ff6c8010bb6
Diff: https://reviews.apache.org/r/37366/diff/
Testing
-------
Thanks,
Maxim Khutornenko