You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/07 07:27:41 UTC

[GitHub] [incubator-tvm] FrozenGene commented on pull request #5486: [TFLITE]Select op support for tflite frontend

FrozenGene commented on pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486#issuecomment-625080456


   LGTM. @siju-samuel After thinking about this pr, I think we should make `get_expr` and `exp_tab.new_const` be private and only public `get_tensor_expr`. Other places use `get_expr` / `exp_tab.new_const` should be replaced as `get_tensor_expr`. Wish you could consider this suggestion after this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org