You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by puyulu <gi...@git.apache.org> on 2016/11/03 08:38:49 UTC

[GitHub] incubator-eagle pull request #603: EAGLE-729:add hbase kerberose principle a...

GitHub user puyulu opened a pull request:

    https://github.com/apache/incubator-eagle/pull/603

    EAGLE-729:add hbase kerberose principle and keytab to provider\ue014

    add hbase kerberose principle and keytab to provider\ue014

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/puyulu/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #603
    
----
commit 98a1f41ca7b60fea081ee773b98df67edb7e815d
Author: yupu <yu...@ebay.com>
Date:   2016-10-20T11:47:03Z

    add health check to pom

commit fdef2256d59fec37bfa071f3724ec95d4a9a8518
Author: yupu <yu...@ebay.com>
Date:   2016-10-20T11:54:33Z

    get valid hostname for hadoop 2.7

commit 7e618f526587b15ae0d3569b8cb5d8add0e4c6be
Author: yupu <yu...@ebay.com>
Date:   2016-10-21T02:30:01Z

    remove view path for topology health check

commit ecf114e6cfb9cc22edecae31f14e16d832b55433
Author: yupu <yu...@ebay.com>
Date:   2016-10-21T03:12:06Z

    remove the unused code after code review

commit 8e35f7bf72989b05ea0a6eb2f71b4531ab4e3dc7
Author: yupu <yu...@ebay.com>
Date:   2016-10-27T05:54:58Z

    integrate with alert engine

commit 050a048a2683e0d7013c9436c5075c4f2d5ac2c1
Author: yupu <yu...@ebay.com>
Date:   2016-10-27T06:07:45Z

    integrate with alert engine

commit cf4628222909fe9d9bdd14260d613e202051792b
Author: yupu <yu...@ebay.com>
Date:   2016-10-27T07:45:16Z

    integrate with alert engine

commit 0d6eeaff52aec391721aab97749e71248036fe5f
Author: yupu <yu...@ebay.com>
Date:   2016-10-27T07:54:42Z

    integrate with alert engine

commit 2154cc2d2d4dc1d060f892722e656a48db1de34b
Author: yupu <yu...@ebay.com>
Date:   2016-10-27T08:25:52Z

    Merge remote-tracking branch 'upstream/master'

commit 94dd3fd6b7427e236c948bb1d7018c1547f4659d
Author: yupu <yu...@ebay.com>
Date:   2016-11-01T02:58:41Z

    integrate with alert engine

commit 039f5fc48c557c8ebeb10da866467fb6d31a258f
Author: yupu <yu...@ebay.com>
Date:   2016-11-01T03:05:55Z

    Merge remote-tracking branch 'upstream/master'

commit 2166e9601048eba7e4f04f3c5421747e418bf2d5
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T07:07:04Z

    change the code after review

commit 900061901e14fa05e7688c16587ed4a6fc92f407
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T07:08:58Z

    change the code after review

commit 1ca364bc1c8015fd76dca03deff16a1ac1fb5ce1
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T07:19:55Z

    change the code after review

commit c55869dba712cce1c15030d7ddd0207e6bc51631
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T10:20:31Z

    remove the conflict

commit 7282776fa68792d309dbf4ae1e7fef206fd6f3cc
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T10:30:53Z

    fix the code conflict

commit 44eac760e0c70a74198ed13bc3cc8bb98e4d4f25
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T11:54:17Z

    add code check style plugin to topology health check

commit f2df5d0ab410a9e3048651bcf3c7654939eae818
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T13:36:34Z

    reformat the code after check style

commit f2ca48e4e0ddfe46649a70414d74b9c90cc0269f
Author: yupu <yu...@ebay.com>
Date:   2016-11-02T13:43:13Z

    change the display name to HBase Zookeeper Quorum

commit 76594e6676f209624dffc7e1ce46ef607b354838
Author: yupu <yu...@ebay.com>
Date:   2016-11-03T08:35:24Z

    add hbase kerberose principle and keytab to provider

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #603: EAGLE-729:add hbase kerberose principle a...

Posted by puyulu <gi...@git.apache.org>.
Github user puyulu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/603#discussion_r86304543
  
    --- Diff: eagle-topology-check/eagle-topology-app/src/main/resources/META-INF/providers/org.apache.eagle.topology.TopologyCheckAppProvider.xml ---
    @@ -88,14 +88,20 @@
                 <description>Hbase Master Principal</description>
                 <value>hadoop/_HOST@EXAMPLE.COM</value>
             </property>
    -     
    +
             <property>
    -            <name>dataSourceConfig.hbase.kerberos.master.principal</name>
    -            <displayName>Hbase Master Principal</displayName>
    +            <name>dataSourceConfig.hbase.kerberos.eagle.principal</name>
    --- End diff --
    
    yes, checked on local machine,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #603: EAGLE-729:add hbase kerberose principle a...

Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/603#discussion_r86303727
  
    --- Diff: eagle-topology-check/eagle-topology-app/src/main/resources/META-INF/providers/org.apache.eagle.topology.TopologyCheckAppProvider.xml ---
    @@ -88,14 +88,20 @@
                 <description>Hbase Master Principal</description>
                 <value>hadoop/_HOST@EXAMPLE.COM</value>
             </property>
    -     
    +
             <property>
    -            <name>dataSourceConfig.hbase.kerberos.master.principal</name>
    -            <displayName>Hbase Master Principal</displayName>
    +            <name>dataSourceConfig.hbase.kerberos.eagle.principal</name>
    --- End diff --
    
    Does it work? I see the code
    
                hBaseConfig.hbaseMasterPrincipal = config.getString("dataSourceConfig.hbase.kerberos.master.principal");
    
    if (hBaseConfig.eaglePrincipal != null && hBaseConfig.eagleKeytab != null
                    && !hBaseConfig.eaglePrincipal.isEmpty() && !hBaseConfig.eagleKeytab.isEmpty()) {
                this.kerberosEnable = true;
                this.hBaseConfiguration.set("hbase.security.authentication", "kerberos");
                this.hBaseConfiguration.set("hbase.master.kerberos.principal", hBaseConfig.hbaseMasterPrincipal);
            }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #603: EAGLE-729:add hbase kerberose principle a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/603


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---