You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/07/03 19:07:58 UTC
[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall
GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/286
Build: Remove symlinks during rpm uninstall
JIRA: MADLIB-1175
`rpm --install` creates three symlinks to `Versions/`, `.../bin`, and
`.../doc`. These symlinks should be deleted during `rpm --erase`.
Additionally, we also delete `Versions/` if it is empty after the erase.
Closes #286
Co-Authored-by: Arvind Sridhar <as...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib feature/rpm_uninstall_symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit cdcd1f6640fe1737fb0ff28393141e4a0cf89d37
Author: Rahul Iyer <ri...@...>
Date: 2018-07-03T19:02:55Z
Build: Remove symlinks during rpm uninstall
JIRA: MADLIB-1175
`rpm --install` creates three symlinks to `Versions/`, `.../bin`, and
`.../doc`. These symlinks should be deleted during `rpm --erase`.
Additionally, we also delete `Versions/` if it is empty after the erase.
Closes #286
Co-Authored-by: Arvind Sridhar <as...@pivotal.io>
----
---
[GitHub] madlib issue #286: Build: Remove symlinks during rpm uninstall
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/286
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/532/
---
[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/286
---
[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/286#discussion_r201501717
--- Diff: pom.xml ---
@@ -66,6 +66,7 @@
<exclude>deploy/preflight.sh</exclude>
<exclude>deploy/RPM/CMakeLists.txt</exclude>
<exclude>deploy/rpm_post.sh</exclude>
+ <exclude>deploy/rpm_post_uninstall.sh</exclude>
--- End diff --
This was done under the assumption that Apache does not need the license header for simple scripts that don't have considerable IP. In this case, we're only removing some files and a directory, so assuming that it's fine to not explicitly tag the license. Let me know if you feel otherwise.
---
[GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/286#discussion_r200793992
--- Diff: pom.xml ---
@@ -66,6 +66,7 @@
<exclude>deploy/preflight.sh</exclude>
<exclude>deploy/RPM/CMakeLists.txt</exclude>
<exclude>deploy/rpm_post.sh</exclude>
+ <exclude>deploy/rpm_post_uninstall.sh</exclude>
--- End diff --
Since this is a new file, we should add the apache license instead of adding it to the exclude list.
---