[GitHub] [arrow-datafusion] jaylmiller commented on pull request #5242: v1 Arrow Row Format in SortExec #5230

["jaylmiller (via GitHub)" <gi...@apache.org>]

jaylmiller commented on PR #5242:
URL: https://github.com/apache/arrow-datafusion/pull/5242#issuecomment-1427047729

   > Thanks @jaylmiller -- this is looking good. Very nice first contribution
   > 
   > I think this code could almost go in as it -- the only thing that I think we need to see is some sort of benchmark improvement.
   > 
   > I looked around in our existing benchmarks to find a benchmark for our sort operator, but was not able to. Maybe @tustvold or @Dandandan or @andygrove know of a preexisting benchmark
   > 
   > If not, perhaps we can adapt some of the code in https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/merge.rs to make a SortExec benchmark
   
   Thanks! Should I add said benchmark to this PR then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org