You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/23 19:18:42 UTC

[GitHub] [camel] javierholguera commented on a change in pull request #4916: [CAMEL-16071] Adds config option 'vertxKafkaClientFactory' to camel-vertx-kafka

javierholguera commented on a change in pull request #4916:
URL: https://github.com/apache/camel/pull/4916#discussion_r563188874



##########
File path: components/camel-vertx-kafka/camel-vertx-kafka-component/src/test/java/org/apache/camel/component/vertx/kafka/operations/VertxKafkaProducerOperationsTest.java
##########
@@ -586,7 +586,7 @@ public void configure(Map<String, ?> configs, boolean isKey) {
 
         @Override
         public byte[] serialize(String topic, Object data) {
-            return stringSerializer.serialize(topic, data.toString());
+            return stringSerializer.serialize(topic, data != null ? data.toString() : null);

Review comment:
       Tests were failing before my changes with a `NullReferenceException`. Seems like `data` was `null` in some tests, causing the issue with the serializer




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org