[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] DDL Native S...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12146#discussion_r58909835
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala ---
    @@ -113,7 +113,10 @@ class HiveSqlAstBuilder extends SparkSqlAstBuilder {
         if (ctx.REPLICATION != null) {
           logWarning("REPLICATION clause is ignored.")
         }
    -    DropTable(visitTableIdentifier(ctx.tableIdentifier).toString, ctx.EXISTS != null)
    +    DropTable(
    +      visitTableIdentifier(ctx.tableIdentifier),
    +      ctx.EXISTS != null,
    --- End diff --
    
    @yhuai It is hard to recognize `Trash` dir. The trash feature is disabled by default.
    
    First, users need to enable `Trash`. http://www.cloudera.com/documentation/archive/cdh/4-x/4-7-1/CDH4-Installation-Guide/cdh4ig_topic_11_2.html#topic_11_2_8_unique_1
    
    Second, the path of `Trash` directory depends on many factors. 
    
    > If the trash directory is not accessible the data will remain in the original location 
    
    > The data is moved to the trash directory in the home directory of the user executing the hive command. 
    
    http://www.cloudera.com/documentation/archive/cdh/4-x/4-7-1/CDH4-Installation-Guide/cdh4ig_hive_trash.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org