[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5750:
URL: https://github.com/apache/cloudstack/pull/5750#discussion_r773871451



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java
##########
@@ -215,7 +219,20 @@ public MigrationResponse migrateData(Long srcDataStoreId, List<Long> destDatasto
         return handleResponse(futures, migrationPolicy, message, success);
     }
 
-    protected Pair<String, Boolean> migrateCompleted(Long destDatastoreId, DataStore srcDatastore, List<DataObject> files, MigrationPolicy migrationPolicy) {
+    private String getObjectType(DataObject dataObject) {
+        if (dataObject instanceof VolumeInfo) {
+            return "volume";

Review comment:
       wouldn't dataObject.getType().getName() make more sense? and do away with the stacked if-statements completely, @sureshanaparti and @Pearl1594 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org