[GitHub] [trafficcontrol] rob05c opened a new pull request #3500: Fix Traffic Ops Delivery Service Update of Old Versions to Omit New Fields

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #3500: Fix Traffic Ops Delivery Service Update of Old Versions to Omit New Fields
URL: https://github.com/apache/trafficcontrol/pull/3500
 
 
   ## What does this PR (Pull Request) do?
   
   Fix Traffic Ops Delivery Service Update of Old Versions to Omit New Fields.
   
   Based on #3493, recommend merging that first. (Would have created merge conflicts otherwise.)
   
   - [x] This PR fixes #3497 OR is not related to any Issue
   
   Includes unit tests, verified by existing API Tests.
   
   No documentation necessary, does not change interface.
   
   Includes CHANGELOG.md entry.
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   PUT a delivery service to a prior version, which has a non-default value in a newer version (for example, `trRequestHeaders` and `/api/1.2`). Verify field is not overwritten.
   
   Run unit tests, run integration tests.
   
   ## If this is a bug fix, what versions of Traffic Ops are affected?
   
   Appears to be in 
   
   - master (21e50eedf)
   - 3.0.0
   - 3.0.1
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services