You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by llambiel <gi...@git.apache.org> on 2015/02/17 17:47:34 UTC
[GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on running ins...
GitHub user llambiel opened a pull request:
https://github.com/apache/cloudstack/pull/81
CS 4.4 Prevent disk resize on running instances under KVM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exoscale/cloudstack fix/no-disk-resize-on-running-vm-kvm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/81.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #81
----
commit 0a6f5184b6e0247118958e24f5bf3338830d172a
Author: Loic Lambiel <ll...@exoscale.ch>
Date: 2015-01-23T12:14:14Z
Prevent disk resize on running instances under KVM
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on
running ins...
Posted by Nux! <nu...@li.nux.ro>.
Thanks a lot, Marcus. Getting live resizing to work without corruptions will be great.
What exactly is your fix?
Lucian
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
----- Original Message -----
> From: "mlsorensen" <gi...@git.apache.org>
> To: dev@cloudstack.apache.org
> Sent: Tuesday, 17 February, 2015 23:00:19
> Subject: [GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on running ins...
> Github user mlsorensen commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/81#issuecomment-74774048
>
> I went digging to see what might have prompted this fix, and it seems that
> qcow2-based storage wasn't notifying qemu when the storage resized. I've
> committed a fix for this that should hit 4.5 and should allow qcow2-based (and
> hopefully RBD as well) disks to get live resized.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on running ins...
Posted by mlsorensen <gi...@git.apache.org>.
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/81#issuecomment-74774048
I went digging to see what might have prompted this fix, and it seems that qcow2-based storage wasn't notifying qemu when the storage resized. I've committed a fix for this that should hit 4.5 and should allow qcow2-based (and hopefully RBD as well) disks to get live resized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on running ins...
Posted by llambiel <gi...@git.apache.org>.
Github user llambiel closed the pull request at:
https://github.com/apache/cloudstack/pull/81
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on
running ins...
Posted by Marcus <sh...@gmail.com>.
Pleas do not commit this. There are plenty of KVM storage types that
support online live resize and have done so going back many revisions.
On Tue, Feb 17, 2015 at 8:47 AM, llambiel <gi...@git.apache.org> wrote:
> GitHub user llambiel opened a pull request:
>
> https://github.com/apache/cloudstack/pull/81
>
> CS 4.4 Prevent disk resize on running instances under KVM
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/exoscale/cloudstack fix/no-disk-resize-on-running-vm-kvm
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/81.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #81
>
> ----
> commit 0a6f5184b6e0247118958e24f5bf3338830d172a
> Author: Loic Lambiel <ll...@exoscale.ch>
> Date: 2015-01-23T12:14:14Z
>
> Prevent disk resize on running instances under KVM
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cloudstack pull request: CS 4.4 Prevent disk resize on running ins...
Posted by llambiel <gi...@git.apache.org>.
Github user llambiel commented on the pull request:
https://github.com/apache/cloudstack/pull/81#issuecomment-74724311
PR closed as per comments on https://issues.apache.org/jira/browse/CLOUDSTACK-6181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---