[jira] [Commented] (AIRFLOW-5485) scheduler_job: replace == None with is_() comparison

["Ash Berlin-Taylor (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944325#comment-16944325 ] 

Ash Berlin-Taylor commented on AIRFLOW-5485:
--------------------------------------------

[~serkef] Yes it appears no one has made a start on this so it's still up for grabs. (Note I updated the ticket slightly as each it was wrong)  AIRFLOW-5490 is another one of the same variety.

> scheduler_job: replace == None with is_() comparison
> ----------------------------------------------------
>
>                 Key: AIRFLOW-5485
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5485
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.10.6
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: ccoss2019, newbie
>
> Note: This ticket's being created to facilitate a new contributor's workshop for Airflow. After the workshop has completed, I'll mark these all available for anyone that might like to take them on.
> airflow/jobs/scheduler_job.py:855
> {code:java}
> .filter(or_(DR.run_id == None,  # noqa: E711 pylint: disable=singleton-comparison
>             not_(DR.run_id.like(BackfillJob.ID_PREFIX + '%'))))
> .outerjoin(DM, DM.dag_id == TI.dag_id)
> .filter(or_(DM.dag_id == None,  # noqa: E711 pylint: disable=singleton-comparison
>         not_(DM.is_paused))) {code}
> We're using {{col == None}} here where we should use {{col.is_(None)}} to avoid confusion as and lint warnings. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)