You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/22 15:56:30 UTC

[GitHub] [rocketmq] Kvicii opened a new issue #3785: about MQClientAPIImpl improvement

Kvicii opened a new issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785


   hi there.
   In MQClientAPIImpl, I see a lot about try cache code blocks, Is this a preparation for the follow-up or can it be completely improved?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Kvicii commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1019637461


   @duhenglucky hi, I think it is possible to merge these code blocks,and I will provide a PR later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Kvicii commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1020798967


   [ISSUE#3785](https://github.com/apache/rocketmq/pull/3793)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1019629896


   @Kvicii please feel free to start a discussion with your design, any optimizations to the code are welcome 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] tianliuliu commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
tianliuliu commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1019684304


   > I wi
   
   yes, PR based on the develop branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Kvicii commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1019637793


   @duhenglucky Does our PR need to be checked out from the develop branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Kvicii commented on issue #3785: about MQClientAPIImpl improvement

Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3785:
URL: https://github.com/apache/rocketmq/issues/3785#issuecomment-1020798967


   [ISSUE#3785](https://github.com/apache/rocketmq/pull/3793)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org