You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/02 04:20:56 UTC
[GitHub] [skywalking-nginx-lua] spacewander opened a new pull request #68: fix: missing `constants` in the rockspsec
spacewander opened a new pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68
Solve the `module 'skywalking.constants' not found` problem.
See https://github.com/apache/apisix/pull/3721/checks?check_run_id=2009896073
for the full error report.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] wu-sheng commented on pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#issuecomment-788673954
@dmsolr Let's call a patch release vote.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] wu-sheng merged pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] dmsolr commented on pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#issuecomment-788639346
Hi, @spacewander please also update `rockspec/skywalking-nginx-lua-master-0.rockspec`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] wu-sheng commented on a change in pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#discussion_r585302006
##########
File path: rockspec/skywalking-nginx-lua-0.4-1.rockspec
##########
@@ -1,5 +1,5 @@
package = "skywalking-nginx-lua"
-version = "0.4-0"
+version = "0.4-1"
source = {
url = "git://github.com/apache/skywalking-nginx-lua",
branch = "v0.4.0",
Review comment:
I think we need to change the tag and run another release vote call, due to the rockspec files have been managed and included by the source tar, which is changed, meaning this is another version.
```suggestion
branch = "v0.4.1",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] spacewander commented on pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#issuecomment-788642775
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nginx-lua] dmsolr commented on a change in pull request #68: fix: missing `constants` in the rockspsec
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#discussion_r585301099
##########
File path: rockspec/skywalking-nginx-lua-0.4-1.rockspec
##########
@@ -1,5 +1,5 @@
package = "skywalking-nginx-lua"
-version = "0.4-0"
+version = "0.4-1"
source = {
url = "git://github.com/apache/skywalking-nginx-lua",
branch = "v0.4.0",
Review comment:
don't we need to update the branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org