You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/10/06 16:43:41 UTC
[Bug 6216] New: check_blank_line_ratio does not properly calculate
blank lines
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Summary: check_blank_line_ratio does not properly calculate
blank lines
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: parkerm@pobox.com
The check_blank_line_ration assumes that the return value for
$pms->get_decoded_body_text_array() is an array of lines. This is incorrect,
it is actually an array of paragraph chunks. The function needs to be adjusted
to account for the different return value.
This causes hits for BLANK_LINES_* rules (which apparently we only have one of
now) to miss.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|security |
Component|Security |Libraries
AssignedTo|security@spamassassin.apach |dev@spamassassin.apache.org
|e.org |
--- Comment #4 from Justin Mason <jm...@jmason.org> 2010-01-27 03:16:41 UTC ---
reassigning, too
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|security |
Component|Security |Libraries
AssignedTo|security@spamassassin.apach |dev@spamassassin.apache.org
|e.org |
--- Comment #6 from Karsten Bräckelmann <gu...@rudersport.de> 2010-03-23 17:42:58 UTC ---
Moving back off of Security, which got changed by accident during the mass
Target Milestone move.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
Target Milestone|3.4.0 |3.4.1
--- Comment #7 from Kevin A. McGrail <km...@pccc.com> ---
Moving all open bugs where target is defined and 3.4.0 or lower to 3.4.1 target
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.3.2 |3.4.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2009-10-30 12:25:50 UTC ---
> The check_blank_line_ration assumes that the return value for
> $pms->get_decoded_body_text_array() is an array of lines. This is incorrect,
> it is actually an array of paragraph chunks. The function needs to be adjusted
> to account for the different return value.
>
> This causes hits for BLANK_LINES_* rules (which apparently we only have one of
> now) to miss.
Considering that the SA::Message::new already compresses multiple blank lines
right during acquisition of a message:
# also merge multiple blank lines into a single one
my $start;
# iterate over lines in reverse order
for (my $cnt=$#message; $cnt>=0; $cnt--) {
$message[$cnt] =~ s/\015\012/\012/;
# line is blank
if ($message[$cnt] !~ /\S/) {
I wonder what is the check_blank_line_ratio supposed to count anyway?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6216] check_blank_line_ratio does not properly calculate blank
lines
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6216
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2009-10-30 13:19:04 UTC ---
Bug 6216: fix Plugin::BodyEval::check_blank_line_ratio()
Sending lib/Mail/SpamAssassin/Plugin/BodyEval.pm
Committed revision 831439.
This fixes the reported concern - but does not address the fact
that blank lines have already been squashed.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.