You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/11/10 04:09:35 UTC
[GitHub] metamodel pull request #136: METAMODEL-1128: Size set and enabled scrolling
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/136
METAMODEL-1128: Size set and enabled scrolling
Here's my stab at a simple fix for METAMODEL-1128.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-1128-elasticsearch-max-rows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 124920babf0000229d0c613074ed5722e13903be
Author: Kasper S�rensen <i....@gmail.com>
Date: 2016-11-10T04:08:08Z
METAMODEL-1128: Size set and enabled scrolling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #136: METAMODEL-1128: Size set and enabled scrolling
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/136
Tested using DataCleaner. Seems to work fine, and reasonably performant; ~6 seconds to do value distribution on 100K records (value distribution run on two columns)... The test set I used is available here: http://ikeptwalking.com/elasticsearch-sample-data/
One thing I didn't test in depth (since I don't know the dataset) was the correctness of the data retrieved. However, _id keys were unique, so I'm pretty that there's at least no problems with getting same data twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #136: METAMODEL-1128: Size set and enabled scrolling
Posted by Juslwk <gi...@git.apache.org>.
Github user Juslwk commented on the issue:
https://github.com/apache/metamodel/pull/136
LGTM! I've tested a bit on my own data set, works great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #136: METAMODEL-1128: Size set and enabled scrolling
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #136: METAMODEL-1128: Size set and enabled scrolling
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/136
Great, let's merge it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #136: METAMODEL-1128: Size set and enabled scrolling
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/136
Code LGTM, but haven't tested.
Should we make a story specifically about looking into using sliced scrolls for performance? I'm not sure how much it'll take, or how big the benefit would be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #136: METAMODEL-1128: Size set and enabled scrolling
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/136
Should we merge, or wait for reporter of METAMODEL-1128 to give feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---