You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nitheesh-daram (via GitHub)" <gi...@apache.org> on 2023/05/21 16:49:02 UTC
[GitHub] [eventmesh] nitheesh-daram opened a new pull request, #3991: [ISSUE #3956 ]
nitheesh-daram opened a new pull request, #3991:
URL: https://github.com/apache/eventmesh/pull/3991
This PR Resolves #3956
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3991: [ISSUE #3956 ]
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3991:
URL: https://github.com/apache/eventmesh/pull/3991#issuecomment-1556475450
You should modify your pr title as this format:
[ISSUE #{the issue number}]{the issue title without the first category tag}.
For example, this pr title should be `[ISSUE #3956]Code optimization.[EventHandler]`.
Other pr you posted should do this modification, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3991: [ISSUE #3956 ]Code optimization.[EventHandler]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3991:
URL: https://github.com/apache/eventmesh/pull/3991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3991: [ISSUE #3956 ]Code optimization.[EventHandler]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3991:
URL: https://github.com/apache/eventmesh/pull/3991#issuecomment-1560675062
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3991](https://app.codecov.io/gh/apache/eventmesh/pull/3991?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6ebbae) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/1798e1f9b5cc212ec75425325bdfb3d1502a4ab5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1798e1f) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head a6ebbae differs from pull request most recent head 720f786. Consider uploading reports for the commit 720f786 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3991 +/- ##
============================================
- Coverage 14.24% 14.23% -0.02%
Complexity 1320 1320
============================================
Files 579 579
Lines 28958 28952 -6
Branches 2815 2799 -16
============================================
- Hits 4125 4121 -4
+ Misses 24441 24440 -1
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/runtime/admin/handler/EventHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRXZlbnRIYW5kbGVyLmphdmE=) | `6.18% <0.00%> (-0.07%)` | :arrow_down: |
| [...ventmesh/runtime/constants/EventMeshConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvbnN0YW50cy9FdmVudE1lc2hDb25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3991/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] nitheesh-daram commented on pull request #3991: [ISSUE #3956 ]
Posted by "nitheesh-daram (via GitHub)" <gi...@apache.org>.
nitheesh-daram commented on PR #3991:
URL: https://github.com/apache/eventmesh/pull/3991#issuecomment-1557566972
@pandaapo sure Will do it ASAP!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org