You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "UOETianleZhang (via GitHub)" <gi...@apache.org> on 2025/06/23 17:50:40 UTC
[PR] Migrations of pinot-controller and pinot-server APIs and dependencies… [pinot]
UOETianleZhang opened a new pull request, #16180:
URL: https://github.com/apache/pinot/pull/16180
## Summary
We want to migrate certain API files to pinot-spi for compatibility gating. broker.api.AccessControl, server.access.AccessControl, and controller.api.access.AccessControl can all be migrated to pinot-spi by:
- Migrating their necessary dependencies - ex. common.request.BrokerRequest - to pinot-spi.
- Updating the pinot-spi pom with the io.netty, javax.ws.rs, javax.annotation and thrift dependencies.
- Disabling the checkstyle checks for the thrift-generated files that were migrated in config/suppressions.xml.
- Applying mvn spotless:apply.
## Major Code Change
Most of files in the PR are generated files. The core changes are only on two thrift files:
- moved pinot-common/src/thrift/query.thrift to pinot-spi
- moved part of request.thrift into two same-named files in spi
## Name Change
- broker.api.AccessControl --> spi.auth.broker.AccessControl
- broker.api.RequesterIdentity --> spi.auth.broker.RequesterIdentity
- common.request.BrokerRequest --> spi.request.BrokerRequest
- common.request.DataSource --> spi.request.DataSource
- common.request.Expression --> spi.request.Expression
- common.request.ExpressionType --> spi.request.ExpressionType
- common.request.Function --> spi.request.Function
- common.request.Identifier --> spi.request.Identifier
- common.request.Join --> spi.request.Join
- common.request.JoinType --> spi.request.JoinType
- common.request.Literal --> spi.request.Literal
- common.request.PinotQuery --> spi.request.PinotQuery
- common.request.QuerySource --> spi.request.QuerySource
- controller.api.access.AccessControl --> spi.auth.controller.AccessType
- controller.api.access.AccessType --> spi.auth.controller.AccessType
- core.auth.FineGrainedAccessControl --> spi.auth.core.FineGrainedAccessControl
- core.auth.TargetType --> spi.auth.core.TargetType
- server.access.AccessControl --> spi.auth.server.AccessControl
- server.access.RequesterIdentity --> spi.auth.server.RequesterIdentity
- query.thrift (originally in pinot-common/thrift)
- request.thrift (split into two files, one is still in pinot-common/thrift)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Migrate AccessControl and its Dependencies to SPI [pinot]
Posted by "UOETianleZhang (via GitHub)" <gi...@apache.org>.
UOETianleZhang commented on PR #16180:
URL: https://github.com/apache/pinot/pull/16180#issuecomment-3002148338
> Why is request.thrift showing up as a new file ?
We are moving part of `request.thrift` from pinot-common to pinot-spi. So we see modification on pinot-common/request.thrift and a new request.thrift created in spi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Migrate AccessControl and its Dependencies to SPI [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16180:
URL: https://github.com/apache/pinot/pull/16180#issuecomment-2998498178
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16180?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `65.07937%` with `22 lines` in your changes missing coverage. Please review.
> Project coverage is 32.99%. Comparing base [(`1a476de`)](https://app.codecov.io/gh/apache/pinot/commit/1a476dea72ebf1c15e14ded28ae60c385f71b2c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`93bd756`)](https://app.codecov.io/gh/apache/pinot/commit/93bd756377e4ff6f686726343b31be6cada1f427?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 323 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/16180?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...c/main/java/org/apache/pinot/spi/request/Join.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FJoin.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9Kb2luLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/pinot/spi/request/BrokerRequest.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FBrokerRequest.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9Ccm9rZXJSZXF1ZXN0LmphdmE=) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/pinot/spi/request/Expression.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FExpression.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9FeHByZXNzaW9uLmphdmE=) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/pinot/spi/request/PinotQuery.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FPinotQuery.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9QaW5vdFF1ZXJ5LmphdmE=) | 80.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/pinot/spi/request/DataSource.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FDataSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9EYXRhU291cmNlLmphdmE=) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/java/org/apache/pinot/spi/request/Function.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9GdW5jdGlvbi5qYXZh) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/pinot/spi/request/Identifier.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FIdentifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9JZGVudGlmaWVyLmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/pinot/spi/request/QuerySource.java](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Frequest%2FQuerySource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcmVxdWVzdC9RdWVyeVNvdXJjZS5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1a476de) and HEAD (93bd756). Click for more details.
>
> <details><summary>HEAD has 68 uploads less than BASE</summary>
>
>| Flag | BASE (1a476de) | HEAD (93bd756) |
>|------|------|------|
>|java-21|10|1|
>|unittests|6|1|
>|unittests1|3|0|
>|skip-bytebuffers-true|4|0|
>|temurin|15|1|
>|unittests2|3|1|
>|skip-bytebuffers-false|8|0|
>|java-11|5|0|
>|integration|9|0|
>|integration2|3|0|
>|integration1|3|0|
>|custom-integration1|3|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16180 +/- ##
=============================================
- Coverage 62.90% 32.99% -29.91%
+ Complexity 1386 660 -726
=============================================
Files 2867 2964 +97
Lines 163354 173489 +10135
Branches 24952 26664 +1712
=============================================
- Hits 102755 57240 -45515
- Misses 52847 111629 +58782
+ Partials 7752 4620 -3132
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <65.07%> (-29.83%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <65.07%> (-29.91%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <65.07%> (-29.91%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16180/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <65.07%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16180?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Migrate AccessControl and its Dependencies to SPI [pinot]
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on PR #16180:
URL: https://github.com/apache/pinot/pull/16180#issuecomment-3001426128
Why is request.thrift showing up as a new file ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org