You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/08/30 17:44:12 UTC
Review Request: RAVE-780: Allow direct linking to subpages on person profile
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6855/
-----------------------------------------------------------
Review request for rave.
Description
-------
Adds support to the person profile page for hash navigation, so that
1) The url hash initializes the page to a particular subpage
2) clicking on a subpage changes the url hash
This will allow a users tab selection to persist across a page refresh, or to be linked directly.
This addresses bug RAVE-780.
https://issues.apache.org/jira/browse/RAVE-780
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1378683
Diff: https://reviews.apache.org/r/6855/diff/
Testing
-------
Chrome, Firefox 15, IE 9
Thanks,
Erin Noe-Payne
Re: Review Request: RAVE-780: Allow direct linking to subpages on person
profile page
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6855/#review10906
-----------------------------------------------------------
Ship it!
LGTM
- Anthony Carlucci
On Aug. 30, 2012, 3:44 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6855/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 3:44 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Adds support to the person profile page for hash navigation, so that
>
> 1) The url hash initializes the page to a particular subpage
> 2) clicking on a subpage changes the url hash
>
> This will allow a users tab selection to persist across a page refresh, or to be linked directly.
>
>
> This addresses bug RAVE-780.
> https://issues.apache.org/jira/browse/RAVE-780
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1378683
>
> Diff: https://reviews.apache.org/r/6855/diff/
>
>
> Testing
> -------
>
> Chrome, Firefox 15, IE 9
>
>
> Thanks,
>
> Erin Noe-Payne
>
>