You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/15 21:51:44 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #18075: [1.7]
Backport #17772
mseth10 opened a new pull request #18075: [1.7] Backport #17772
URL: https://github.com/apache/incubator-mxnet/pull/18075
## Description ##
Backport #17772 to branch v1.7.x
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mseth10 commented on issue #18075: [1.7] Backport
#17772
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #18075: [1.7] Backport #17772
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-614299298
@samskalicky @leezu please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18075: [1.7]
Backport #17772
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18075: [1.7] Backport #17772
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-614298526
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, website, centos-cpu, miscellaneous, clang, windows-gpu, centos-gpu, unix-gpu, windows-cpu, edge, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mseth10 commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-616714472
@mxnet-label-bot add [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-618079828
@leezu @pengzhao-intel @ciyongch please help merge this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-617583510
@mseth10 please check the failed CI, and backport this PR to v1.7.x branch as well. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-617629527
Hi @ciyongch , the CI got re-triggered automatically on this PR. It was passing earlier.
I have created another PR for v1.7.x #18122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] rondogency commented on pull request #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
rondogency commented on pull request #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-619443168
@szha @leezu @eric-haibin-lin Can you help to merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-617681059
Thanks @mseth10 , I will track that PR before code freeze.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-616695966
@ciyongch @PatricZhao please help merge! thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-619342431
@TaoLv @pengzhao-intel please help to merge this PR, which is already merged in both master and v1.7.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18075: [1.x] Backport #17772
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18075:
URL: https://github.com/apache/incubator-mxnet/pull/18075#issuecomment-616897741
@pengzhao-intel Please take a look and help merge.
@mseth10 can you backport this PR to v1.7.x release branch as well (as the code rebase was already done)? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org