[jira] [Commented] (GOBBLIN-1273) Pull or Conf file loading failures are not easy to understand

["Jay Sen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GOBBLIN-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202767#comment-17202767 ] 

Jay Sen commented on GOBBLIN-1273:
----------------------------------

Hi [~sdasapache], I have a couple of different kind of fixes that take cares of such issues.

basically standalone mode converts the platform config in property file as oppose to other modes which directly uses the config as HOCON.

I opened both of this issue to resolve such issues and also make overall config usage better. 
 # GOBBLIN-926 use typesafe config consistently everywhere
 # GOBBLIN-942

Basically, There are lot of HOCON features that Gobblin can leverage if it standardize it to use across all kinds of configs.

let me know your thoughts.

> Pull or Conf file loading failures are not easy to understand
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-1273
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1273
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Shirshanka Das
>            Priority: Minor
>
> When config files fail to load (specifically hocon files), Gobblin doesn't log which file and which line number caused the failure. 
>  
> e.g. if a .conf file with unquoted : characters is found in a standalone server's config directory, the startup aborts with the following message:
>  
> _Exception in thread "main" java.lang.IllegalStateException: Expected to be healthy after starting_
> _at com.google.common.base.Preconditions.checkState(Preconditions.java:150)_
> _at com.google.common.util.concurrent.ServiceManager.awaitHealthy(ServiceManager.java:278)_
> _at org.apache.gobblin.runtime.app.ServiceBasedAppLauncher.start(ServiceBasedAppLauncher.java:168)_
> _at org.apache.gobblin.scheduler.SchedulerDaemon.main(SchedulerDaemon.java:75)_
> _Exception in thread "JobScheduler STARTING" com.typesafe.config.ConfigException$BadPath: Reader: 30: Token not allowed in path expression: ':' (you can double-quote this token if you really want it here)_
> _at com.typesafe.config.impl.Parser.parsePathExpression(Parser.java:1095)_
> _at com.typesafe.config.impl.Parser.parsePathExpression(Parser.java:1049)_
> _at com.typesafe.config.impl.Parser.access$000(Parser.java:27)_
> _..._
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)