[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1078: HDDS-3794. Topology Aware read does not work correctly in XceiverClientGrpc

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1078:
URL: https://github.com/apache/hadoop-ozone/pull/1078#discussion_r441303172



##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -314,15 +314,17 @@ private XceiverClientReply sendCommandWithRetry(
           // Pull the Cached DN to the top of the DN list
           Collections.swap(datanodeList, 0, getBlockDNCacheIndex);
         }
-      } else if (topologyAwareRead) {

Review comment:
       > Yea, I did wonder why getBlock() is not part of that IF block. I guess it makes sense to add it in just in case, as it will do no harm.
   > 
   > I am not really fully up-to-speed on the read path from the Ozone client - would it be normal for several getblock calls to be made against the same pipeline (XceiverClientGrpc instance)? Ie do we expect getBlock to benefit from the cached connection sometimes?
   
   Yes, it is quite possible to use the same XceiverClientGrpc instanvce to read for multiple blocks for multiple keys.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org