[jira] [Resolved] (KAFKA-5841) Open old index files with read-only permission

["Ismael Juma (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ismael Juma resolved KAFKA-5841.
--------------------------------
    Resolution: Not A Problem

We have a constructor parameter for this, so I don't think we need this method.

> Open old index files with read-only permission
> ----------------------------------------------
>
>                 Key: KAFKA-5841
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5841
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: huxihx
>            Priority: Major
>
> Since old index files do not change, we may as well drop the write permission needed when opening them. From the doc comments in {{OffsetIndex}}, it sounds like we may have had this implemented at one point:
> {code}
>  * Index files can be opened in two ways: either as an empty, mutable index that allows appends or
>  * an immutable read-only index file that has previously been populated. The makeReadOnly method will turn a mutable file into an 
>  * immutable one and truncate off any extra bytes. This is done when the index file is rolled over.
> {code}
> So we should either support this or (if there is good reason not to) update the comment.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)