You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/01 00:45:12 UTC

[kudu-CR] Remove InMemoryEnv completely

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3258

to review the following change.

Change subject: Remove InMemoryEnv completely
......................................................................

Remove InMemoryEnv completely

Every time we extend the Env interface we need to create a mock
implementation for MemEnv. MemEnv really has no measurable benefit for
us. Let's delete some code!!!

Also removed a couple of unneeded #includes.

Change-Id: I4f26e321ec68a15b511db522e4d85470da7905f8
---
M src/kudu/tablet/deltafile-test.cc
M src/kudu/util/CMakeLists.txt
D src/kudu/util/memenv/memenv-test.cc
D src/kudu/util/memenv/memenv.cc
D src/kudu/util/memenv/memenv.h
M src/kudu/util/rolling_log-test.cc
6 files changed, 0 insertions(+), 972 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/3258/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f26e321ec68a15b511db522e4d85470da7905f8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>