You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aleksandar Vidakovic (Jira)" <ji...@apache.org> on 2020/10/09 18:40:00 UTC

[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless

    [ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211277#comment-17211277 ] 

Aleksandar Vidakovic commented on FINERACT-1188:
------------------------------------------------

[~vorburger] thanks for creating the sub-tasks. Ok, I see now how you intend to do this... fineract-provider would not be a module in this first step. Excellent.

> README and other files are not covered by Spotless
> --------------------------------------------------
>
>                 Key: FINERACT-1188
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1188
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Michael Vorburger
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>
> Would it be possible to extract JUST the work related to make README and other files are covered by Spotless fromĀ [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial formatting changes itself which Spotbugs made once you change the layout, but without any build change - just send them first, separately - get that out of the way?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)