You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by brandtg <gi...@git.apache.org> on 2014/08/26 22:14:54 UTC
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
GitHub user brandtg opened a pull request:
https://github.com/apache/helix/pull/2
[HELIX-470] Netty-based IPC layer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brandtg/helix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit f2475fa9a6123052fea2588cdd4e439ddc7af020
Author: Greg Brandt <br...@gmail.com>
Date: 2014-08-26T20:14:36Z
[HELIX-470] Netty-based IPC layer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16854782
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
In any case, we need to figure out what is right in general, and apply it to all our submodules. I have created https://issues.apache.org/jira/browse/HELIX-509 to track this work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16854005
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
@kanakb, sorry looks like Helix already put NOTICE file in each module that released separately.
I guess if we package this separately then NOTICE for this module should stay but I think the top level NOTICE file should have copy of the content.
Does each NOTICE file in the sub module does not have copy to top NOTICE file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16853492
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
So is this going to separate source zip? If this would be under the parent umbrella of main source the NOTICE need to be on top level directory [1]
[1] http://www.apache.org/legal/src-headers.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16853182
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
Forgot to comment this one. Please move NOTICE file content to NOTICE in top level Helix directory. Then you can remove this one.
NOTICE file should be bundled into one when making releases and just copy this to main NOTICE will make packaging easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16854042
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
Ah, I think we have things somewhat backwards. Right now all of our submodules have LICENSE and NOTICE files, but I guess these only need to be at the top level? Helix has a single source release and per-module binary releases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16855377
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
@hsaputra Greg is on vacation; I can take care of that during the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/2#issuecomment-53754601
If no one has any objections, I plan to merge this for our 0.7.1 beta release so that we can increase collaboration on it and move things forward iteratively.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16853293
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
Since we release Helix as per-module binary bundles, personally I think having specific NOTICE files makes more sense -- that way, people can pick and choose which modules to use without needing to worry about dependencies present in other modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16854152
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
@hsaputra Yes, the top-level NOTICE is currently a superset of all submodule NOTICE files, though this is done manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16741557
--- Diff: helix-ipc/LICENSE ---
@@ -0,0 +1,273 @@
+
--- End diff --
Do not need extra LICENSE file here since the main LICENSE file will be used when doing the packaging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-470] Netty-based IPC layer
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/helix/pull/2#discussion_r16855212
--- Diff: helix-ipc/NOTICE ---
@@ -0,0 +1,33 @@
+Apache Helix
--- End diff --
Sounds good, for this PR we could keep the NOTICE file to be inline with others.
@brandtg, could you add copy of this module NOTICE file to the top level one like other modules?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---