You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/10 06:59:28 UTC
[GitHub] [apisix-website] Yiyiyimu commented on pull request #297: fix: darkMode enhanced
Yiyiyimu commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817090748
Post my comments here
> @iamayushdas Nice! For me, I have some other suggestions. Just take it or leave it with your preferences 😁
>
> 1. It might be a good idea to propose a PR, so we could have a more instinctive view of the actual website rather than screenshots
> 2. For the description part, IMO, we could have a darker background with lighter(whitish) text to be compatible with other parts of the whole website. And still, the background of this part better different from other ones.
> 3. Grayish title is absolutely great, it's the main part of the dark mode. But the problem is it seems too dark right now so the contract between text and background is not clear enough. A example from DuckDuckGo
> 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org